https://bugs.kde.org/show_bug.cgi?id=409041

Bernd Buschinski <b.buschin...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/kde/
                   |                            |kdevelop/commit/d1f58562046
                   |                            |494b78e17c50c2fdab5c2800d9a
                   |                            |af
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Bernd Buschinski <b.buschin...@googlemail.com> ---
Git commit d1f58562046494b78e17c50c2fdab5c2800d9aaf by Bernd Buschinski.
Committed on 19/07/2019 at 17:21.
Pushed by buschinski into branch 'master'.

Fix code completion for nameless structs/unions with the same member

Summary:
The code completion always shows the first declaration it finds for a matching
name.
This works fine as long as the parent has a name, for nameless structs/unions
it just returns the first declaration it finds.
Fix this by checking that the found declaration has the expected type.

Test Plan:
See https://bugs.kde.org/show_bug.cgi?id=409041 for example code
or see the unit test in this patch.

Reviewers: #kdevelop, apol

Reviewed By: #kdevelop, apol

Subscribers: kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D22455

M  +13   -0    plugins/clang/codecompletion/context.cpp
M  +43   -2    plugins/clang/tests/test_codecompletion.cpp
M  +2    -0    plugins/clang/tests/test_codecompletion.h

https://invent.kde.org/kde/kdevelop/commit/d1f58562046494b78e17c50c2fdab5c2800d9aaf

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to