https://bugs.kde.org/show_bug.cgi?id=321190
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.17.0
Resolution|INTENTIONAL |FIXED
Latest Commit| |https://commits.kde.org/kwi
| |n/4dd4ca8f1c44226e0b2fc5e32
| |ca911cc06402480
--- Comment #97 from Nate Graham <n...@kde.org> ---
Git commit 4dd4ca8f1c44226e0b2fc5e32ca911cc06402480 by Nate Graham.
Committed on 21/06/2019 at 16:25.
Pushed by ngraham into branch 'master'.
[effects/presentwindows] Allow closing windows on middle-click
Summary:
Plasma's Task manager exposes an optional feature whereby the user
can middle-click on a window to close it, but the Present Windows effect
does not do the same.
The presence of a close button you can left-click does not replace the
desirable
feature to be able to middle-click on a window to close it, because then the
whole window becomes a click target, so it can be much much faster than
having to aim for the little close button. Also it's off by default, so a user
who goes out of their way to turn it on is signaling that they want to accept
the
risk of accidentally closing a window by accident.
Finally, the feature is not allowed for left-click, so people can never
accidentally
wreck Present Windows for themselves by assigning it to left-click by accident
and then mistakenly closing their windows.
This reverts commit 55585514f926d1251148e876bfe9ce3504432997.
FIXED-IN: 5.17.0
Test Plan:
Set "Close window" in the Present windows effect, trigger effect, and
middle-click on window
{F6815303}
Reviewers: #kwin, davidedmundson, broulik, zzag, #plasma, hein, mart
Reviewed By: #kwin, #plasma, mart
Subscribers: mart, abetts, apol, zzag, luebking, kossebau, graesslin, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D21083
M +5 -0 effects/presentwindows/presentwindows.cpp
M +2 -1 effects/presentwindows/presentwindows.h
M +10 -0 effects/presentwindows/presentwindows_config.ui
https://commits.kde.org/kwin/4dd4ca8f1c44226e0b2fc5e32ca911cc06402480
--
You are receiving this mail because:
You are watching all bug changes.
