https://bugs.kde.org/show_bug.cgi?id=388592
David Redondo <k...@david-redondo.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Version Fixed In| |19.08.0 Latest Commit| |https://commits.kde.org/spe | |ctacle/1d568009f73f3b633635 | |11eddded623f16be86bb Resolution|--- |FIXED --- Comment #2 from David Redondo <k...@david-redondo.de> --- Git commit 1d568009f73f3b63363511eddded623f16be86bb by David Redondo. Committed on 21/06/2019 at 15:41. Pushed by davidre into branch 'master'. Port to KGlobalAccel Summary: Port to KGlobalAccel. This enables us to drop khotkeys and display a configuration dialog inside the application. The update script correctly sets the defaults and migrates possibly user changed shortcuts. I didn't know where to place the KActionCollection and put it in SpectacleConfig for the moment. FIXED-IN: 19.08.0 Test Plan: Shortcuts should work as before. Reviewers: #spectacle, davidedmundson, ngraham Reviewed By: #spectacle, davidedmundson, ngraham Subscribers: asturmlechner, ngraham, #spectacle Tags: #spectacle Maniphest Tasks: T10519 Differential Revision: https://phabricator.kde.org/D19310 M +2 -0 CMakeLists.txt D +0 -4 ExtraDesktop.sh M +15 -4 desktop/CMakeLists.txt A +115 -0 desktop/MigrateShortcuts.cpp [License: UNKNOWN] * M +5 -0 desktop/org.kde.spectacle.desktop D +0 -620 desktop/spectacle.khotkeys A +4 -0 desktop/spectacle_shortcuts.upd M +3 -0 src/CMakeLists.txt M +8 -0 src/Gui/SettingsDialog/SettingsDialog.cpp A +44 -0 src/Gui/SettingsDialog/ShortcutsOptionsPage.cpp [License: UNKNOWN] * A +31 -0 src/Gui/SettingsDialog/ShortcutsOptionsPage.h [License: UNKNOWN] * M +41 -0 src/SpectacleConfig.cpp M +4 -0 src/SpectacleConfig.h M +24 -1 src/SpectacleCore.cpp M +2 -0 src/SpectacleCore.h M +1 -1 tests/CMakeLists.txt The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page. https://commits.kde.org/spectacle/1d568009f73f3b63363511eddded623f16be86bb -- You are receiving this mail because: You are watching all bug changes.