https://bugs.kde.org/show_bug.cgi?id=407554
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/kde/
| |krita/commit/eb61160966ddc7
| |94cfd02a9225e577f0844e51e0
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #14 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit eb61160966ddc794cfd02a9225e577f0844e51e0 by Dmitry Kazakov.
Committed on 07/06/2019 at 10:46.
Pushed by dkazakov into branch 'master'.
Fix a crash when creating a text shape
Every KoShapeController used to reset the global "shape document" in its
KoDocumentResourceManager. The problem is that in Krita we have multiple
KoShapeController-s, but the resource manager is the only one. It means
that every shape selection or shape layer used to reset the pointer to
the global "shape document" to its own one. The only reason why we didn't
have too many crashes is that almost noone uses this "shape document".
Ideally we should:
1) Remove KoDocumentResourceManager::GlobalShapeController resource. This
resource is not global to the document, but is created per-layer. The only
user of it atm is the legacy text tool, which should be deprecated.
2) Remove KoDocumentResourceManager at all. There is no much use of it
anymore. Its main user is legacy text tool.
M +18 -5 libs/flake/KoDocumentResourceManager.cpp
M +13 -3 libs/flake/KoDocumentResourceManager.h
M +0 -3 libs/flake/KoShapeController.cpp
M +1 -1 libs/flake/KoShapeRegistry.cpp
M +1 -1 libs/flake/tests/TestKoShapeRegistry.cpp
M +2 -4 libs/flake/text/KoSvgTextShape.cpp
M +9 -6 libs/ui/KisDocument.cpp
M +1 -1 libs/ui/flake/kis_dummies_facade_base.h
M +26 -0 libs/ui/flake/kis_shape_controller.cpp
M +6 -0 libs/ui/flake/kis_shape_controller.h
M +1 -1 plugins/flake/textshape/TextShapeFactory.cpp
https://invent.kde.org/kde/krita/commit/eb61160966ddc794cfd02a9225e577f0844e51e0
--
You are receiving this mail because:
You are watching all bug changes.
