https://bugs.kde.org/show_bug.cgi?id=407280

            Bug ID: 407280
           Summary: Skrooge flatpak unintentionally builds unused tests
           Product: skrooge
           Version: Trunk from git
          Platform: Flatpak
                OS: Linux
            Status: REPORTED
          Severity: minor
          Priority: NOR
         Component: general
          Assignee: guillaume.deb...@gmail.com
          Reporter: skierp...@gmail.com
                CC: steph...@mankowski.fr
  Target Milestone: ---

Looking at the latest Skrooge flatpak build log
https://binary-factory.kde.org/job/Skrooge_flatpak/13/consoleFull
it seems to build all skrooge tests. But I don't think it runs them and they
aren't installed in the flatpak.

The log has the warning:

  09:34:52    Manually-specified variables were not used by the project:
  09:34:52  
  09:34:52      ENABLE_TESTING

and
https://cgit.kde.org/flatpak-kde-applications.git/tree/org.kde.skrooge.json#n86
has:
         "config-opts":[
            "-DQT4_BUILD=OFF",
            "-DQCA_SUFFIX=qt5",
            "-DENABLE_TESTING=OFF",

but looking at Skrooge's CMakeLists.txt line 23:
  OPTION(SKG_BUILD_TEST "Build the test" ON)

perhaps that line in org.kde.skrooge.json should be
            "-DSKG_BUILD_TEST=OFF",

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to