https://bugs.kde.org/show_bug.cgi?id=403453
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kde
| |clarative/0aab7d23a2ce155c4
| |beb5cf77fcac02c93b183b7
Status|CONFIRMED |RESOLVED
--- Comment #7 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 0aab7d23a2ce155c4beb5cf77fcac02c93b183b7 by David Edmundson.
Committed on 18/04/2019 at 16:14.
Pushed by davidedmundson into branch 'master'.
Plotter: Scope GL Program to lifespan of scenegraph node
Summary:
Currently the QOpenGLProgram was static. This works when you only have
one OpenGL context that is never invalidated.
Instead we shoul have a new program created for each context. There is
no benefit of being static when we can use the cached shader loading.
As we need a program per context, we would need to handle windowChanged
and sceneGraphInvalidated manually. Instead we can scope the program to
the QSGNode which will be deleted and recreated on the render thread
automatically by the scene graph backend.
We can also drop ManagedTextureNode and use
QSGSimpleTextureNode::setOwnsTexture which does the same thing.
Test Plan:
Created a CPU load viewer on my panel
Dragged it to my desktop
Previously that didn't render anything
Now it does
It should fix the crashes that we
see on window moves and handling sceneGraphInvalidated
Reviewers: #plasma
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20656
M +66 -40 src/qmlcontrols/kquickcontrolsaddons/plotter.cpp
M +2 -9 src/qmlcontrols/kquickcontrolsaddons/plotter.h
https://commits.kde.org/kdeclarative/0aab7d23a2ce155c4beb5cf77fcac02c93b183b7
--
You are receiving this mail because:
You are watching all bug changes.
