https://bugs.kde.org/show_bug.cgi?id=405649

            Bug ID: 405649
           Summary: help:/ handler loses fragments
           Product: frameworks-kguiaddons
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: kdelibs-b...@kde.org
          Reporter: sit...@kde.org
  Target Milestone: ---

Some of our our software (particularly KCMs) have documentation paths set
including fragments.

e.g. kinfocenter's memory module has

X-DocPath=kinfocenter/index.html#kcm_memory

which expressed as an url will be 'help:/kinfocenter/index.html#kcm_memory'.
The fragment is lost in UrlHandler::openHelp where it only picks up the path
but not the fragment:

                const QUrl
httpUrl(QStringLiteral("https://docs.kde.org/index.php?branch=stable5&language=";)+QLocale().name()+QStringLiteral("&application=")
+
                    QCoreApplication::applicationName() +
QStringLiteral("&path=") + url.path());

Same probably for a potential query?
Also the path likely should be percent-encoded as otherwise it's unclear if the
fragment applies to the master url or the path= url.

e.g. the run final url should be something like

https://docs.kde.org/index.php?branch=stable5&language=en_US&application=kinfocenter&path=%2Fkinfocenter%2Findex.html%23kcm_memory

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to