https://bugs.kde.org/show_bug.cgi?id=404833

--- Comment #11 from RJVB <rjvber...@gmail.com> ---
(In reply to Kai Uwe Broulik from comment #10)
> > and that that was deemed acceptable (was a while ago though).
> 
> It still is as that binds your application to a specific Qt version 

I was talking about the plasma integration plugin. Binding that one to a
specific Qt version shouldn't be much of an issue - and usually isn't when you
only upgrade the Qt version you're using it with.

> Embed it like you asked for?

How would you do that?

> We had that in KDE4, it was called KFileDialog, and got abandoned in favor
> of a QFileDialog + QPT approach which will get you native file dialogs on
> other platforms.

[OT]
If we disregard the question whether or not QFileDialog should only give
platform-native dialogs there is the issue that this approach makes it
cumbersome for applications to provide a "KDE-style" dialog everywhere by using
something that would logically be called KFileDialog. There are lots of
cross-platform KDE widgets that extend or improve on Qt counterparts, why
wouldn't there be one for file dialogs? It's not like every platform has
equally featurerich/convenient file dialogs as the KDE one. And it isn't like
it's a shocking crime to want to offer something better to your users. Or to
offer a homegeneous experience regardless of what platform you're running on.

I've gotten a glimpse of what it takes to implement a KFileDialog class that's
based on KFileWidget, and that duplicates much of the code which is also in the
integration plugin. To me it would make sense to reintroduce KFileDialog, and
use that class in the integration plugin. KDE Applications can be coerced
through the KDE HIG to keep using QFileDialog, but other applications no longer
have to duplicate "jealously guarded" code ;)

> I don't see how QFile*Dialog* would be something that is
> supported to be embedded elsewhere.

My second patch on the Scribus ticket linked under "additional info" above does
exactly that.

> KFileWidget. However, there's also the issue of not being able to add custom
> widgets to such dialogs, since the native dialogs aren't real Qt widgets you
> could add a widget to.

You could be wrong there. Qt's native widgets look native but aren't
necessarily the exact same ones you get when running native non-Qt code - at
least not on Mac. Or they are, but native widgets that are displayed in a
window that's also some kind of QWidget.
I see that the Mac native file dialogs also go through
QPlatformFileDialogHelper, and it seems you can indeed not embed those either.
But that's not really relevant here...

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to