https://bugs.kde.org/show_bug.cgi?id=342224
Igor Poboiko <igor.pobo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |RESOLVED
Latest Commit| |https://commits.kde.org/bal
| |oo/5e1add922ab2a1d6b4a2131b
| |846c5a9d964c43a2
Resolution|--- |FIXED
--- Comment #3 from Igor Poboiko <igor.pobo...@gmail.com> ---
Git commit 5e1add922ab2a1d6b4a2131b846c5a9d964c43a2 by Igor Poboiko.
Committed on 15/02/2019 at 15:41.
Pushed by poboiko into branch 'master'.
[baloo/KInotify] Notify if folder was moved from unwatched place
Summary:
If a folder was moved from an unwatched place, `KInotify` will receive an
`EventMoveTo` event,
which doesn't have an `EventMoveFrom` counterpart, and thus it will emit only
`created` signal
for the moved directory, but not its contents.
It also won't install watches for the directory (as it does in `EventCreate`).
Instead use FilteredDirIterator to emit created() signal for all the contents
as well, and add inotify watches.
It should also now handle the race condition if a directory was created
and files were moved inside it before an inotify watch for this directory was
installed.
Note that it's not really realted to symbolic links, one just has to move a
folder from excluded place to included.
Test Plan:
Added a test case for `KInotifyTest`, similar to one described in Bug 342224.
It passes now.
Reviewers: #baloo, #frameworks, ngraham, bruns
Reviewed By: #baloo, ngraham, bruns
Subscribers: bruns, ngraham, kde-frameworks-devel, #baloo
Tags: #frameworks, #baloo
Differential Revision: https://phabricator.kde.org/D18698
M +37 -0 autotests/unit/file/kinotifytest.cpp
M +24 -4 src/file/kinotify.cpp
M +8 -0 src/file/kinotify.h
https://commits.kde.org/baloo/5e1add922ab2a1d6b4a2131b846c5a9d964c43a2
--
You are receiving this mail because:
You are watching all bug changes.
