https://bugs.kde.org/show_bug.cgi?id=356141

Vlad Zagorodniy <vladz...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |n/0d7415336f0aeed4f85d28761
                   |                            |cff78131d20fce6

--- Comment #8 from Vlad Zagorodniy <vladz...@gmail.com> ---
Git commit 0d7415336f0aeed4f85d28761cff78131d20fce6 by Vlad Zagorodniy.
Committed on 15/02/2019 at 13:51.
Pushed by vladz into branch 'master'.

[effects] Make sure that all effects reset the streaming buffer

Summary:
The streaming buffer is shared so we have to reset it before rendering
something. Otherwise, it's basically undefined behavior.

For example, if the streaming buffer had been used for rendering a
geometry with some color, then the Background Contrast effect may crash
in GLVertexBuffer::bindArrays, it all depends on whether there is any
bounded GLShader. To fix that, the buffer has to be reset.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D19034

M  +1    -0    effects/backgroundcontrast/contrast.cpp
M  +1    -0    effects/blur/blur.cpp

https://commits.kde.org/kwin/0d7415336f0aeed4f85d28761cff78131d20fce6

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to