https://bugs.kde.org/show_bug.cgi?id=402072
Anna Medonosova <anna.medonos...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/kri
| |ta/b1c8ba60f0a246fb97a47cf2
| |5e6876194b145af0
--- Comment #2 from Anna Medonosova <anna.medonos...@gmail.com> ---
Git commit b1c8ba60f0a246fb97a47cf25e6876194b145af0 by Anna Medonosova.
Committed on 22/12/2018 at 15:15.
Pushed by amedonosova into branch 'master'.
Palette Docker: bug 402072; color selection in the combobox
Summary:
This diff fixes two issues:
1, bug 402072, where the user is unable to reselect a previously
selected color from the palette after picking another color by other
means.
This is fixed by clearing currentIndex in KisPaletteView upon FG color
change in the resource provider. That way the swatch stays selected, so
the user knows which color they had selected before, but enables them to
reselect the color.
2, Another issue, probably originating from commit 69915f533a6: if the
user selects a color in the KisPaletteComboBox, nothing happens.
KisPaletteComboBox calls KisPaletteView::selectClosestColor() to select
the clicked color in the palette. However, from said commit, the
function is called only with specific setting on. I have added another
slot specifically for KisPaletteComboBox, which unconditionally calls
said function.
Reviewers: #krita, woltherav
Reviewed By: #krita, woltherav
Subscribers: woltherav
Tags: #krita
Differential Revision: https://phabricator.kde.org/D17728
M +1 -1 libs/widgets/KisPaletteComboBox.cpp
M +16 -0 libs/widgets/kis_palette_view.cpp
M +12 -0 libs/widgets/kis_palette_view.h
M +13 -1 plugins/dockers/palettedocker/palettedocker_dock.cpp
M +4 -0 plugins/dockers/palettedocker/palettedocker_dock.h
https://commits.kde.org/krita/b1c8ba60f0a246fb97a47cf25e6876194b145af0
--
You are receiving this mail because:
You are watching all bug changes.
