https://bugs.kde.org/show_bug.cgi?id=333759
--- Comment #5 from Aetf <7437...@gmail.com> --- Posted on Phabricator now: https://phabricator.kde.org/D1351 Well, yes, it can be done by just make IVariableController::handleEvent correctly updates m_active{Frame,Thread} even if IVariableController::autoUpdate is UpdateNone. No need to touch IVariableController::setAutoUpdate though. But I think there is duplication. Maybe my wording isn't clear, but the patch isn't removing the "only update when active frame/thread chagnes" functionality, as we only call IVariableController::update when handling IDebugSession::thread_or_frame_changed event. So no need to do the duplicate check (The update in IVariableController::setAutoUpdate handles different situations and is irrelevant here. However, I do wonder if it is needed all the time) Besides, m_active{Frame,Thread} only mirror the same value in FrameStackModel::current{Frame,Thread} and it requires extra effort to keep them synced. So in my opinion we should remove m_active{Frame,Thread} to simplify the logic. I understand removing them breaks binary compatibility. If that's what you are concerned, then I'm OK to change to the simpler workaround. -- You are receiving this mail because: You are watching all bug changes.
