https://bugs.kde.org/show_bug.cgi?id=400992
Thomas Surrel <thomas.sur...@protonmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/dol
| |phin/e710a6431160aee57b1eab
| |34b11dfe64e341898c
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #1 from Thomas Surrel <thomas.sur...@protonmail.com> ---
Git commit e710a6431160aee57b1eab34b11dfe64e341898c by Thomas Surrel.
Committed on 17/11/2018 at 13:43.
Pushed by thsurrel into branch 'Applications/18.12'.
Do not disconnect all StorageAccess signals when unmounting
Summary:
The problem is caused by the fact device interfaces returned by
Solid (e.g. item->device().as<Solid::StorageAccess>()) are not
full objects, but only references/pointers to a per-device-object,
i.e. requesting the same interface for a device will return the same
address every time.
If the interface is used used in multiple places, calling disconnect
on the interface address disconnects the signals for all users.
Test Plan:
In Dolphin, mount a local partition (e.g. a Windows partition)
then unmount it (right click on it in Places, then Unmount).
Try to access it again by clicking on it in Places, we should
get access to it correctly.
Reviewers: #dolphin, #frameworks, bruns, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: elvisangelaccio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D16857
M +2 -1 src/panels/places/placesitemmodel.cpp
https://commits.kde.org/dolphin/e710a6431160aee57b1eab34b11dfe64e341898c
--
You are receiving this mail because:
You are watching all bug changes.
