https://bugs.kde.org/show_bug.cgi?id=396091
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/bre
| |eze-gtk/6ec73bf0693821ffda1
| |ea262e8b7c162242dc495
Status|CONFIRMED |RESOLVED
--- Comment #5 from Nate Graham <n...@kde.org> ---
Git commit 6ec73bf0693821ffda1ea262e8b7c162242dc495 by Nate Graham, on behalf
of Matthias Groß.
Committed on 31/10/2018 at 18:39.
Pushed by ngraham into branch 'master'.
share common values for both Breeze and Breeze-dark GTK themes
Summary:
As described in bug #396091, the Breeze-dark theme is often neglected in
updates. This patch fixes #396091 and some additional, related inconsistencies,
enables sharing the basic stuff like shape, size, style, etc. of components in
a common single css file while keeping the colour definitions separated from
that in different files for both the light and dark theme.
This allows easier changes, easier maintenance because of less LOC, less
duplicate code as well as easier extensibility for potential additional colour
schemes like [[ https://hig.kde.org/style/color/light.html | light ]] or [[
https://hig.kde.org/style/color/high.html | high-contrast ]].
I only did this for GTK 3.20 for now. If you like the effort, it could (and
maybe should) get extended to other versions.
Further potential steps in the same direction of saving code would be going
back to SASS, which is used by many other popular GTK themes and was used by
Breeze-gtk as well in the past. The only downside of that is that the SASS
source files would have to be "compiled" to CSS prior to packaging.
Test Plan: I don't know of any automated test suites comparing UI components. I
have already posted screenshots in the original bug report and can post
additional ones of the new state for comparison. Apart from that, my manual
sparse testing makes me feel the dark GTK theme looks and feels much more
consistent to Breeze now.
Reviewers: jackg, #breeze, #plasma, ngraham
Reviewed By: #breeze, ngraham
Subscribers: grmat, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16365
M +60 -3707 Breeze-dark-gtk/gtk-3.20/gtk.css
C +0 -122 Breeze-gtk/gtk-3.20/common.css [from:
Breeze-gtk/gtk-3.20/gtk.css - 097% similarity]
M +1 -3692 Breeze-gtk/gtk-3.20/gtk.css
https://commits.kde.org/breeze-gtk/6ec73bf0693821ffda1ea262e8b7c162242dc495
--
You are receiving this mail because:
You are watching all bug changes.
