https://bugs.kde.org/show_bug.cgi?id=400291

Harald Sitter <sit...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|DOWNSTREAM                  |FIXED
      Latest Commit|                            |https://commits.kde.org/kio
                   |                            |-extras/0e129b10ae30bd985ce
                   |                            |1e38d50deb23a685f095c

--- Comment #6 from Harald Sitter <sit...@kde.org> ---
Git commit 0e129b10ae30bd985ce1e38d50deb23a685f095c by Harald Sitter.
Committed on 31/10/2018 at 10:23.
Pushed by sitter into branch 'master'.

make libssh module default to the "new" libssh config by default

Summary:
- rename module from LibSSH to libssh so casing is consistent with config
- module now quietly attempts to find libssh by config and returns if found
- if it was not found we'll fall back to manual lookup
- adjust actual FOUND variable use for correct case
- fix package case in properties set up (this is case sensitive)

this is singularly necessary because the config file is not correctly
packaged in ubuntu 18.04 (LTS)

https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1800135/comments/2

This reverts 3b1fd6bd8866da2dadd33705af53613236503efc.

Test Plan: builds in ubuntu docker container and with a system that has a
proper config

Reviewers: broulik, asn

Reviewed By: broulik

Subscribers: kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D16529

M  +3    -3    CMakeLists.txt
A  +113  -0    cmake/Findlibssh.cmake

https://commits.kde.org/kio-extras/0e129b10ae30bd985ce1e38d50deb23a685f095c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to