https://bugs.kde.org/show_bug.cgi?id=375131

--- Comment #7 from Stefan Brüns <stefan.bru...@rwth-aachen.de> ---
Git commit 1509ca51c5ed5b78d56a794e466eb4b9d0bd3f3b by Stefan Brüns.
Committed on 25/10/2018 at 14:17.
Pushed by bruns into branch 'master'.

[Extractor] Make extractor crash resilient

Summary:
Connect to QProcess::finished to detect the exit status. In case the
process has crashed, signal the indexer.

On a crash, restart the process and feed it a smaller batch. If the
crashing batch contains only a single file, mark the file as failed, i.e.
add it to the "failedid" db and remove it from the content indexing db
to avoid further indexing attempts.

Test Plan:
start `balooctl monitor`
add a file known to crash the extractor to an indexable path
touch an unproblematic file
-> indexer crashes on first file and continues with the second

Reviewers: #baloo, #frameworks, poboiko, ngraham

Reviewed By: #baloo, ngraham

Subscribers: broulik, apol, kde-frameworks-devel

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D16266

M  +17   -3    src/file/extractorprocess.cpp
M  +2    -0    src/file/extractorprocess.h
M  +17   -1    src/file/filecontentindexer.cpp
M  +10   -0    src/file/filecontentindexerprovider.cpp
M  +1    -0    src/file/filecontentindexerprovider.h

https://commits.kde.org/baloo/1509ca51c5ed5b78d56a794e466eb4b9d0bd3f3b

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to