https://bugs.kde.org/show_bug.cgi?id=398100

--- Comment #6 from Vlad Zagorodniy <vladz...@gmail.com> ---
Git commit 769f2659ddfff8096b826238595a26e5f21c39ad by Vlad Zagorodniy.
Committed on 09/10/2018 at 08:04.
Pushed by vladz into branch 'master'.

[effects] Make Scale and Glide effects Wayland-friendly

Summary:
The Scale effect and the Glide effect have to animate only ordinary
windows(i.e. the ones that are considered to be apps).

On X11, in order to distinguish ordinary windows from combo box popups,
popup menus, and other popups, those effects check whether given window
is managed.

On Wayland, there is no concept of managed/unmanaged windows.

XDG Shell protocol defines 2 surface roles:
* xdg_toplevel;
* and, xdg_popup.

The former can be used to implement typical windows, the ones that can
be minimized, maximized, etc.

The latter can be used to implement tooltips, popup menus, etc. Thus,
that's a good criteria to filter popup windows.

Reviewers: #kwin, graesslin, davidedmundson

Reviewed By: #kwin, graesslin, davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15117

M  +8    -1    effects/glide/glide.cpp
M  +8    -1    effects/scale/scale.cpp
M  +21   -0    libkwineffects/kwineffects.cpp
M  +38   -0    libkwineffects/kwineffects.h
M  +11   -0    shell_client.cpp
M  +2    -0    shell_client.h
M  +28   -0    toplevel.h

https://commits.kde.org/kwin/769f2659ddfff8096b826238595a26e5f21c39ad

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to