https://bugs.kde.org/show_bug.cgi?id=361516

Igor Poboiko <igor.pobo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.15.0
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kwi
                   |                            |n/ca1b5ea1070ccd23dd742f35d
                   |                            |449e4a531ff7951

--- Comment #18 from Igor Poboiko <igor.pobo...@gmail.com> ---
Git commit ca1b5ea1070ccd23dd742f35d449e4a531ff7951 by Igor Poboiko.
Committed on 14/09/2018 at 09:36.
Pushed by poboiko into branch 'master'.

[effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect

Summary:
Bugs occurred because KWin was not very happy when windows were painted during
CubeSlideEffect::paintScreen().
Another issue is that blur, although it was supposed to, did not work at all
(haven't found appropriate bug on bugzilla).
As well as background contrast effect.

This patch does the following thing:

 - Adopted WindowForceBlur / WindowForceBackgroundContrast logic from
SlideEffect, instead of panels/stickyWindows QSets (those become useless
anyway)
 - Added shouldAnimate code, which determines whether a window should be
animated with the cube (i.e. ordinary windows) or should stick (i.e. panels or
pinned windows, if corresponding options are checked in the settings)
 - It paints an additional non-transformed screen, on which it paints only
"sticky" windows. This is done because otherwise KWin would apply blur not
behind the OSD, but on the same place on moving cube face.
 - (in addition) switched to new Qt5 connect syntax.

Reviewers: #kwin, zzag

Differential Revision: https://phabricator.kde.org/D15175
Related: bug 362360
FIXED-IN: 5.15.0

M  +87   -54   effects/cube/cubeslide.cpp
M  +10   -3    effects/cube/cubeslide.h

https://commits.kde.org/kwin/ca1b5ea1070ccd23dd742f35d449e4a531ff7951

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to