https://bugs.kde.org/show_bug.cgi?id=396185

--- Comment #2 from Sergei Gureev <bem...@gmail.com> ---
Thank you!
But it fails again:

[  4%] Building CXX object src/klib/CMakeFiles/libkring.dir/kcfg_settings.cpp.o
In file included from
/tmp/yaytmp-1000/ring-kde-git/src/build/src/klib/kcfg_settings.cpp:4:
/tmp/yaytmp-1000/ring-kde-git/src/build/src/klib/kcfg_settings.h:12:18: error:
Declaring type ‘class ConfigurationSkeleton’ final would enable
devirtualization of 1 call [-Werror=suggest-final-types]
 class LIB_EXPORT ConfigurationSkeleton : public KConfigSkeleton
                  ^~~~~~~~~~~~~~~~~~~~~
/tmp/yaytmp-1000/ring-kde-git/src/build/src/klib/kcfg_settings.cpp:246:1:
error: Declaring virtual destructor of ‘class ConfigurationSkeleton’ final
would enable devirtualization of 1 call [-Werror=suggest-final-methods]
 ConfigurationSkeleton::~ConfigurationSkeleton()
 ^~~~~~~~~~~~~~~~~~~~~
/tmp/yaytmp-1000/ring-kde-git/src/build/src/klib/kcfg_settings.cpp: In
destructor ‘ConfigurationSkeleton::~ConfigurationSkeleton()’:
/tmp/yaytmp-1000/ring-kde-git/src/build/src/klib/kcfg_settings.cpp:248:38:
error: potential null pointer dereference [-Werror=null-dereference]
   s_globalConfigurationSkeleton()->q = nullptr;
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
/tmp/yaytmp-1000/ring-kde-git/src/build/src/klib/kcfg_settings.cpp: In static
member function ‘static ConfigurationSkeleton* ConfigurationSkeleton::self()’:
/tmp/yaytmp-1000/ring-kde-git/src/build/src/klib/kcfg_settings.cpp:19:41:
error: potential null pointer dereference [-Werror=null-dereference]
   if (!s_globalConfigurationSkeleton()->q) {
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
/tmp/yaytmp-1000/ring-kde-git/src/build/src/klib/kcfg_settings.cpp:21:38:
error: potential null pointer dereference [-Werror=null-dereference]
     s_globalConfigurationSkeleton()->q->read();
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
/tmp/yaytmp-1000/ring-kde-git/src/build/src/klib/kcfg_settings.cpp:24:43:
error: potential null pointer dereference [-Werror=null-dereference]
   return s_globalConfigurationSkeleton()->q;

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to