https://bugs.kde.org/show_bug.cgi?id=395890
--- Comment #4 from Henrik Fehlauer <rk...@lab12.net> --- Looked more into this: - Showing a warning in Browse mode instead of the Rename / Overwrite / Cancel" dialog worked before, so it is actually a regression, caused by 6ca0b93e6029 in KIO (according to git blame). Perhaps "setData" in PreviewItemDelegate::setModelData now needs to be replaced with manual handling of the renaming, using KIO::moveAs instead of the implicit KIO::rename. - Showing no warning in View mode is a regression introduced while porting to Qt 5 (it works fine with a KDE 4 based version, but is already broken with Gwenview 14.12.0, KIO 5.7.0, KJobWidgets 5.0.0, KCoreAddons 5.0.0 or somewhere else in KF5). In FileOperations::rename, showErrorMessage() does not seem to have an effect anymore. As nothing relevant changed in fileoperations.cpp in that time frame, this is likely a behavioural change in KF5 (either a bug, or something Gwenview missed to be ported to). To fix the issue, the call can be removed in exchange for setAutoErrorHandlingEnabled(true). However, the better dialog from KIO::moveAs might make more sense. It might be worth checking whether the better dialog for renames in both View and Browse mode can be implemented in a single place, e.g. in FileOpsContextManagerItem::rename. -- You are receiving this mail because: You are watching all bug changes.
