https://bugs.kde.org/show_bug.cgi?id=395651

--- Comment #9 from Chris <chrisret...@gmx.com> ---
(In reply to Fabian Vogt from comment #8)
> cmake -D MOZILLA_DIR=/opt/asdf results in
> 
>  * MOZILLA_DIR, Mozilla directory is '/opt/asdf'
> 
> which means it works as expected.

As you expected.

Would not call that a standard method. Most Plasma cmakes use
KDE_INSTALL_LIBDIR, CMAKE_INSTALL_LIBDIR or LIB_SUFFIX. The first two are
accepted parameters with the cmake of plasma-browser-integration. That is what
should be expected. 

You are giving the user the option of CMAKE_INSTALL_PREFIX but not the option
of  CMAKE_INSTALL_LIBDIR which most cmakes do. By having to set MOZILLA_DIR
directly one looses both options. Yes I could have just simply set the
MOZZILA_DIR directly to start with and not file this bug which I consider
valid, resolved. I filed this because you hard coded a location which on some
distribution does not work.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to