https://bugs.kde.org/show_bug.cgi?id=386034
Huon <h...@plonq.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/gwe
| |nview/984b9737f0796c48ab68f
| |e0f60bc179e26fbcf62
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
Version Fixed In| |18.08.0
--- Comment #2 from Huon <h...@plonq.org> ---
Git commit 984b9737f0796c48ab68fe0f60bc179e26fbcf62 by Huon Imberger.
Committed on 24/06/2018 at 01:26.
Pushed by huoni into branch 'master'.
Allow dragging from View mode to external applications
Summary:
This patch adds drag functionality to {nav View} mode. A
drag operation is only initiated if dragging wouldn't
otherwise do something, e.g. when zoomed and the image is
pannable, or the crop tool is active.
In order to get a drag pixmap for all cases (videos
included), we use a ThumbnailProvider to generate a file
preview. However, if the image is modified, we generate a
new pixmap using the edited version. Using
`MimeTypeUtils::selectionMimeData`, this should mean the
drag pixmap always matches the image the receiving
application gets.
FIXED-IN: 18.08.0
{F5781358}
Test Plan:
Drag from View mode, comparison mode.
Try raster, SVG, and video file types, including when the
image is modified (cropped or rotated).
Panning a zoomed image should still be possible.
Drag operation should always get a thumbnail/icon pixmap
representing the dropped image.
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Tags: #gwenview
Differential Revision: https://phabricator.kde.org/D11877
M +2 -2 lib/documentview/abstractdocumentviewadapter.h
M +6 -0 lib/documentview/abstractimageview.cpp
M +2 -0 lib/documentview/abstractimageview.h
M +106 -0 lib/documentview/documentview.cpp
M +3 -0 lib/documentview/documentview.h
M +5 -0 lib/documentview/rasterimageviewadapter.cpp
M +1 -0 lib/documentview/rasterimageviewadapter.h
M +5 -0 lib/documentview/svgviewadapter.cpp
M +2 -0 lib/documentview/svgviewadapter.h
https://commits.kde.org/gwenview/984b9737f0796c48ab68fe0f60bc179e26fbcf62
--
You are receiving this mail because:
You are watching all bug changes.
