https://bugs.kde.org/show_bug.cgi?id=394507

Elvis Angelaccio <elvis.angelac...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/dol
                   |                            |phin/588abbf1b6994245d987c0
                   |                            |d07c2b074cb76fc034
   Version Fixed In|                            |18.04.2
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #5 from Elvis Angelaccio <elvis.angelac...@kde.org> ---
Git commit 588abbf1b6994245d987c0d07c2b074cb76fc034 by Elvis Angelaccio.
Committed on 03/06/2018 at 11:08.
Pushed by elvisangelaccio into branch 'Applications/18.04'.

Fix crash in PlacesItem::setUrl()

Connections to lambda slots without context/receiver argument can lead
to crashes, because if the receiver is deleted Qt won't delete the connection
as it normally would when the receiver is specified.

This patch moves the slot from the lambda in PlacesItem (which is not a
QObject)
to PlacesItemSignalHandler. This fixes the `dolphinmainwindowtest` crash
we currently have on master, and should also fix bug #394507 which has
the very same stacktrace.
FIXED-IN: 18.04.2

M  +1    -3    src/panels/places/placesitem.cpp
M  +7    -0    src/panels/places/placesitemsignalhandler.cpp
M  +2    -0    src/panels/places/placesitemsignalhandler.h

https://commits.kde.org/dolphin/588abbf1b6994245d987c0d07c2b074cb76fc034

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to