https://bugs.kde.org/show_bug.cgi?id=370975

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/sol
                   |                            |id/d735708ff11c40ee6b9bee64
                   |                            |544250d55067403f

--- Comment #50 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit d735708ff11c40ee6b9bee64544250d55067403f by David Edmundson.
Committed on 02/05/2018 at 12:48.
Pushed by davidedmundson into branch 'master'.

Update mount point after mount operations

Summary:
The order of udisks evaluation has changed from:

call Mount
propertiesChanged
mount call returns

call Mount
mount call returns
propertiesChanged

The mount has finished, but the property is not yet updated.

Solid caches properties, updating them when they change. This worked
before but due to the re-ordering client code gets "setupDone" requests
the mount point gets an outdated version from the cache and we get
errors. Invalidating the cache causes us to round-trip to the udisks
daemon meaning we'll have the correct values.

Test Plan:
Diagnosed but with dbus-monitor trace
Asked someone on the bug report to test this

Reviewers: #plasma

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D12648

M  +7    -0    src/solid/devices/backends/udisks2/udisksdevice.cpp
M  +1    -0    src/solid/devices/backends/udisks2/udisksdevice.h
M  +4    -4    src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

https://commits.kde.org/solid/d735708ff11c40ee6b9bee64544250d55067403f

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to