https://bugs.kde.org/show_bug.cgi?id=393087

Boudewijn Rempt <b...@valdyas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
                   |ta/25a628eb1ae047b37045cda4 |ta/ba377491cdd4bc825de07035
                   |bc705dfc2b0b5731            |f7ed2e0a05545c84

--- Comment #4 from Boudewijn Rempt <b...@valdyas.org> ---
Git commit ba377491cdd4bc825de07035f7ed2e0a05545c84 by Boudewijn Rempt, on
behalf of Dmitry Kazakov.
Committed on 02/05/2018 at 11:54.
Pushed by rempt into branch 'krita/4.0'.

Fix crashes on undo/redo of vector path points operations

1) KoPathToolSelection keeps pointers to the shapes and its path points,
   therefore it should subscribe to the updates on the shapes and their
   points (using ShapeChangeListener framework).

2) The patch also fixes a lot of bugs in "Join by segment" and
   "Merge points", which should behave correctly now.

3) The patch also partially implements "keep path point selection"
   idea, which selects newly created point after each operation. The
   stuff is achieved using KoPathShape::PointSelectionChangeListener
   listener.
Related: bug 393209
(cherry picked from commit f919e7f2dbed028e8fdae89b58ed6f5af26760db)

M  +1    -0    libs/flake/CMakeLists.txt
M  +70   -2    libs/flake/KoPathShape.cpp
M  +12   -0    libs/flake/KoPathShape.h
M  +2    -0    libs/flake/KoPathShape_p.h
M  +5    -11   libs/flake/commands/KoMultiPathPointMergeCommand.cpp
M  +9    -0    libs/flake/commands/KoPathBreakAtPointCommand.cpp
A  +70   -0    libs/flake/commands/KoPathMergeUtils.cpp     [License: GPL
(v2+)]
A  +37   -0    libs/flake/commands/KoPathMergeUtils.h     [License: GPL (v2+)]
M  +13   -1    libs/flake/commands/KoPathPointInsertCommand.cpp
M  +98   -120  libs/flake/commands/KoPathPointMergeCommand.cpp
M  +11   -0    libs/flake/commands/KoPathPointRemoveCommand.cpp
M  +63   -39   libs/flake/commands/KoSubpathJoinCommand.cpp
M  +10   -3    libs/flake/commands/KoSubpathJoinCommand.h
M  +15   -2    libs/flake/tools/KoPathTool.cpp
M  +3    -0    libs/flake/tools/KoPathTool.h
M  +62   -0    libs/flake/tools/KoPathToolSelection.cpp
M  +6    -1    libs/flake/tools/KoPathToolSelection.h
M  +4    -0    plugins/flake/pathshapes/ellipse/EllipseShape.cpp
M  +2    -0    plugins/flake/pathshapes/enhancedpath/EnhancedPathShape.cpp
M  +4    -0    plugins/flake/pathshapes/rectangle/RectangleShape.cpp
M  +2    -0    plugins/flake/pathshapes/spiral/SpiralShape.cpp
M  +2    -0    plugins/flake/pathshapes/star/StarShape.cpp

https://commits.kde.org/krita/ba377491cdd4bc825de07035f7ed2e0a05545c84

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to