https://bugs.kde.org/show_bug.cgi?id=388684

Kai Uwe Broulik <k...@privat.broulik.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.12.0
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-workspace/86fe986934742
                   |                            |ea2a877bf8cb8393c6f0591ef58

--- Comment #11 from Kai Uwe Broulik <k...@privat.broulik.de> ---
Git commit 86fe986934742ea2a877bf8cb8393c6f0591ef58 by Kai Uwe Broulik.
Committed on 11/01/2018 at 13:01.
Pushed by broulik into branch 'master'.

[Notifications] Use custom DragHelper instead of Qt's Drag attached property

Qt's Drag attached property doesn't like it at all when it gets deleted during
drag. (QTBUG-65701)
Even though we try very hard to keep the popup open, when you have multiple
notification applets, their dialogs don't know each
other but access a shared data engine.

This means that, since there can only we one hovered dialog at a time, another
notification applet might still dismiss the
notification and have our dialog close.

By using a singleton NotificationHelper we 1.) decouple the Drag from the item
and 2.) share the "is dragging" state between applets.
FIXED-IN: 5.12.0

Differential Revision: https://phabricator.kde.org/D9754

M  +24   -15   applets/notifications/package/contents/ui/ThumbnailStrip.qml
M  +1    -0    applets/notifications/plugin/CMakeLists.txt
A  +84   -0    applets/notifications/plugin/draghelper.cpp     [License: GPL
(v2+)]
A  +53   -0    applets/notifications/plugin/draghelper.h     [License: GPL
(v2+)]
M  +10   -0    applets/notifications/plugin/notificationshelperplugin.cpp

https://commits.kde.org/plasma-workspace/86fe986934742ea2a877bf8cb8393c6f0591ef58

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to