https://bugs.kde.org/show_bug.cgi?id=388682

Sergio Martins <smart...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/cla
                   |                            |zy/451664d8726b176e23f9bbef
                   |                            |9d61d21073f0f198
         Resolution|---                         |FIXED

--- Comment #1 from Sergio Martins <smart...@kde.org> ---
Git commit 451664d8726b176e23f9bbef9d61d21073f0f198 by Sergio Martins.
Committed on 08/01/2018 at 23:51.
Pushed by smartins into branch '1.3'.

rule-of-three: Improve last commit

Now it also fixes the second bug
Our previous fix wasn't being run because it was in the if (numImplemeted ==
1),
so failed for the case where we have a user-dtor, user-copy-ctor and
deleted-copy-assign.

Moving the check out of the if fixes it.

M  +11   -6    src/checks/level2/ruleofthree.cpp
A  +16   -0    tests/rule-of-three/bug388682.cpp     [License: UNKNOWN]  *
A  +0    -0    tests/rule-of-three/bug388682.cpp.expected
M  +3    -0    tests/rule-of-three/config.json

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://commits.kde.org/clazy/451664d8726b176e23f9bbef9d61d21073f0f198

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to