https://bugs.kde.org/show_bug.cgi?id=359289
--- Comment #4 from Andreas Arnez <ar...@linux.vnet.ibm.com> --- (In reply to Florian Krohm from comment #3) > Thanks for the patch. > As Mark said: none/tests/s390x/Makefile.am needs adjustment. Otherwise the > popcnt test does not get built during "make check". Right, I missed to include that change. Thanks to Mark for pointing out. > In opcodes.h you define POPCNT. Good! Why not use it in popcnt.c? Just a matter of taste. I prefer leaving the choice of operand registers to the compiler, like you would do in production code. > Can you add a check_popcnt call in popcnt.c where all input bits are 1? Sure. Any particular reason for testing this specific value? > We also need configury to check whether the machine has the POPCNT insn. And > only if the machine supports that opcode we should build the test. Not sure about that one. The patch always emulates the instruction, independent of the host capabilities. Do you think that should change? Wouldn't that be inconsistent with setting facility bit 45? > Other than that the patch looks good. Thanks for reviewing! -- You are receiving this mail because: You are watching all bug changes.
