https://bugs.kde.org/show_bug.cgi?id=388232
--- Comment #1 from Mauro Carvalho Chehab <mchehab+...@kernel.org> --- (In reply to Peter Eszlari from comment #0) > https://flatpak.org / https://flathub.org > > I wanted to build a flatpak of kaffeine and publish it on flathub. Then I > noticed that libdvbv5 depends on libudev, which is not available in flatpak: > > https://github.com/flatpak/flatpak/issues/961 > > On the other hand, mesa/libdrm removed their libudev support and one can > access /dev/dri from flatpak without problems. Maybe the same can be done > for libdvbv5 (or make it optional). > I never used Flatpak/AppImage. If I understand well, you want to generate a package that won't depend on libudev, right? Well, libdvbv5 relies on libudev to discover the devices, although it could be possible to add a patch at v4l-utils that would disable udev, while keepinb libdvb. However, that will also remove some new libdvbv5 features that dynamically discover the Digital TV devices. However, in the case of Kaffeine, our plan is to replace Solid by those new libdvbv5 features for device discovery, as they allows it to detect and use devices connected to a remote machine as well. I have already some patches using this new feature on a devel branch, but support for remote devices there is incomplete. My plan is to work on it during those two weeks. I might eventually work on a way to use libdvbv5 with the new APIs without udev, but not sure how hard would be. Yet, I don't plan to do anything like that any time soon, as I want first to provide support for remote devices on Kaffeine. Yet, if you want to work on such patch, be my guest. One solution that occurred to me would be to force Kaffeine to optionally use a static version of libdvbv5, with something like: diff --git a/CMakeLists.txt b/CMakeLists.txt index 5eea1e096c44..0abd1dc05705 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -11,6 +11,7 @@ set(KAFFEINE_VERSION ${KAFFEINE_MAJOR_VERSION}.${KAFFEINE_MINOR_VERSION}.${KAFFEINE_PATCH_VERSION}${KAFFEINE_EXTRA_VERSION}) option(BUILD_TOOLS "Build the helper tools" OFF) +option(PREFER_STATIC "Prefer static libraries" OFF) # Minimal versions where build is known to work cmake_minimum_required(VERSION 2.8.12) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 7ca4bc698331..1fef6328862e 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -52,7 +52,11 @@ target_link_libraries(kaffeine Qt5::Sql Qt5::X11Extras KF5::XmlGui KF5::I18n KF5 KF5::DBusAddons ${X11_Xscreensaver_LIB} ${VLC_LIBRARY}) if(HAVE_DVB) - target_link_libraries(kaffeine ${Libdvbv5_LIBRARIES}) + if (PREFER_STATIC) + target_link_libraries(kaffeine "-lpthread" "-ludev") + STRING(REGEX REPLACE ".so$" ".a" Libdvbv5_LIBRARIES ${Libdvbv5_LIBRARIES}) + endif(PREFER_STATIC) + target_link_libraries(kaffeine ${Libdvbv5_LIBRARIES}) endif(HAVE_DVB) install(TARGETS kaffeine ${INSTALL_TARGETS_DEFAULT_ARGS}) However, the above actually doesn't solve the issue, as, at least on the distributions I use, all based on systemd, libudev is only shipped as a dynamic library. It seems that systemd developers don't like the idea of providing a static library for it. See, for example: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1358372 Btw, that's likely why there aren't any Flatpak for libudev: by design, libudev has to be an exact match of systemd's version. On the bright side, all systemd-based distros should have libudev installed by default, as this is part of systemd-libs package. So, a "distro-independent" package would likely run on all systemd-based distros. > An alternative for cross distro packaging would be AppImage. Not as > convenient as Flatpak, but it's able to link against host libraries: > > https://appimage.org Not sure what should be done at Kaffeine in order to support it, but perhaps the above patch would help, by forcing the usage of static libraries where possible. -- You are receiving this mail because: You are watching all bug changes.
