https://bugs.kde.org/show_bug.cgi?id=385408

--- Comment #26 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to Vadim Barkov from comment #23)
> Is the current patch okay? Could you merge it or tell me what's wrong with
> it please?

For the record, I didn't find any further problems with the patch, except
maybe a few nits:
- In none/tests/s390x/vector.c, test_once(vgbm) is
  invoked twice for no apparent reason.
- In none/tests/s390x/vector.h, the comment for s390_test_generate() seems
  misleading.  In particular it states the the macro takes up to three
  arguments (in fact, just two?) and that the arguments can be modified
  for testing (not sure what that means -- example?).
- Some minor spelling issues and long lines.

I can't approve the patch though.  Julian, are you OK with the patch now?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to