https://bugs.kde.org/show_bug.cgi?id=387391
--- Comment #22 from Venca B Spam <vbs...@centrum.cz> --- (In reply to Sven Brauch from comment #21) > Thank you very much for looking into this! Ideally, you could submit your > full patch to phabricator.kde.org, which is our usual platform for reviewing > changes. I am a bit confused by your github link, because the code you end > up with is exactly what I see in our current codebase ...? Thank you for your attention. The final change is just single line in plugins/cmake/cmakeserverimportjob.cpp which changes canonicalFilePath() call to absoluteFilePath(). (https://github.com/vbspam/kdevelop/commit/d1898acee23e8324a718414c5e4ccb0fcae0d460#diff-a96baafe1c9ef34cbcc5cbc05978cfaeR139). >From my point of view, even it pass all my test cases, it is not ready to submit due to the following reasons: a) needs some cleanup (variable names, remove comments) b) although I know why it works, I do not know why the original idea of Milian Wolff does not work with my test cases (https://github.com/vbspam/kdevelop/commit/e1500e1f) Please note, I put my changes to branch dev-387391, which I hope I properly link in this issue (at least it works on my laptop). -- You are receiving this mail because: You are watching all bug changes.
