https://bugs.kde.org/show_bug.cgi?id=376257
--- Comment #7 from Julian Seward <jsew...@acm.org> ---
Philippe, thanks for having the patience (and finding a way!) to redo this
without changing Vex. This looks good to me. Just a few minor comments.
+ /* Take into account the first_ip_delta and first_sp_delta. */
startRegs.r_pc += (Long)(Word)first_ip_delta;
+ startRegs.r_sp += (Long)first_sp_delta;
You might as well remove the (Word) cast for the r_pc line, since it's
redundant.
+ if (fixupSP_needed) {
+ hName = "evh__mem_help_cwrite_4_fixupSP";
+ hAddr = &evh__mem_help_cwrite_4_fixupSP;
+ } else {
+ hName = "evh__mem_help_cwrite_4";
+ hAddr = &evh__mem_help_cwrite_4;
+ }
Please add a short comment somewhere, explaining the difference
between (eg) evh__mem_help_cwrite_4_fixupSP and evh__mem_help_cwrite_4.
+ the SP needed to unwind need to be fixed UP.
Did you mean "UP" and not "up"?
+static Bool check_cached_rcec_ok (Thr* thr, Addr previous_frame0)
+{
Is this just for debugging, or is it used in "normal" runs? If it
is for normal runs, is it safe -- meaning, can it cause the run to
fail if some of the heuristics it uses are not quite right?
If it is just for debugging (which I am hoping), please add a comment to say
that.
--
You are receiving this mail because:
You are watching all bug changes.
