https://bugs.kde.org/show_bug.cgi?id=385939
--- Comment #2 from Ivo Raisr <iv...@ivosh.net> ---
Thank you for the patch and kudos for documenting the new option in the manual.
>From the high level perspective, I have the following comments and questions:
* It is not clear what happens in the XML mode. Is the XML correctly finalized
with --exit-on-first-error=yes?
* Valgrind does not print anything after it encounters the first error with
--exit-on-first-error=yes, even with '-v'. This could be potentially confusing
to the users. However they get what they wanted, anyway.
* There is no test case present in the patch. Please supply a test case which
exercises --exit-on-first-error=yes in text and XML mode. The test case will
belong under none/tests.
>From the lower level perspective, I have the following comments:
* Source code block indentation is 3 spaces (yes, 3 spaces). Please check all
occurrences.
* New option is listed in usage_NORETURN() but
none/tests/cmdline{1,2].stdout.exp do not reflect it. Please run the regression
tests.
* Please do not introduce trailing whitespace.
--
You are receiving this mail because:
You are watching all bug changes.
