https://bugs.kde.org/show_bug.cgi?id=365050
David Faure <fa...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://commits.kde.org/kxm |https://commits.kde.org/kwi
|lgui/ba889143d684326f0b8b19 |dgetsaddons/c6191993c7e5ea4
|88ea12073c95cc8ffe |873f0635a6fac79773c9cb96c
--- Comment #3 from David Faure <fa...@kde.org> ---
Git commit c6191993c7e5ea4873f0635a6fac79773c9cb96c by David Faure.
Committed on 07/10/2017 at 16:29.
Pushed by dfaure into branch 'master'.
KAcceleratorManager: set icon text on actions to remove CJK markers
Summary:
This replaces the KToolBar event filter hack to solve the same issue:
when an action text appears in a menu we want the & accelerator, while in
toolbars wewant that removed. Qt takes care of it, except for the more tricky
case of CJK markers: "<chinese here> (&O)" where &O exists only to get an ascii
accelerator.
Instead of hacking the text at painting time (!) it's much more robust to
remove " (&O)" from action texts and sett hat as the icon text upfront.
With this in, we can remove the KToolBar hack which leads to endless repaints.
Related: bug 377859
Test Plan: Unittest
Reviewers: mardelle, ilic, sandsmark
Subscribers: #frameworks
Differential Revision: https://phabricator.kde.org/D7964
M +31 -6 autotests/kacceleratormanagertest.cpp
M +1 -0 src/CMakeLists.txt
A +106 -0 src/common_helpers.cpp [License: LGPL (v2+)]
A +46 -0 src/common_helpers_p.h [License: LGPL (v2+)]
M +21 -0 src/kacceleratormanager.cpp
https://commits.kde.org/kwidgetsaddons/c6191993c7e5ea4873f0635a6fac79773c9cb96c
--
You are receiving this mail because:
You are watching all bug changes.
