https://bugs.kde.org/show_bug.cgi?id=384880

--- Comment #5 from Milian Wolff <m...@milianw.de> ---
a) if my memory serves me right (I've written this a long time ago), I think
the WatchFiles there may have been required to get notified about file deletion
events. Anyhow, I agree that this needs to be improved somehow. Maybe this
isn't needed anymore, maybe it was never required in the first place. Writing
better tests for this would be the first way to fix this.

b) You said:

"I'm going to go with the null hypothesis that the QFSW API isn't new and has
had ample opportunity for fine-tuning by Qt experts. We're just using it in a
very intensive way here."

>From my long time experience working with Qt, this shouldn't be your null
hypothesis. I've found and fixed quite a few glaring performance issues in Qt
over the years, and most simply arose when you pushed a bit more load at the
public API in ways that apparently noone did so far. Maybe we do that here due
to the misconfiguration in a). Nevertheless ruling out performance
optimizations upstream is a very bad idea at this stage.

Just looking at the profile reports, QStringList pops up - a very bad idea if
that's getting queries in O(N) all the time. Using a QSet or sorted vector
could already dramatically improve the runtime performance.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to