https://bugs.kde.org/show_bug.cgi?id=383915
Henrik Fehlauer <rk...@lab12.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version Fixed In| |17.12.0 Latest Commit| |https://commits.kde.org/oku | |lar/bd20e48c3c8c82ed11ae73a | |ae0467c8ef49fca3b Status|ASSIGNED |RESOLVED --- Comment #12 from Henrik Fehlauer <rk...@lab12.net> --- Git commit bd20e48c3c8c82ed11ae73aae0467c8ef49fca3b by Henrik Fehlauer. Committed on 12/09/2017 at 19:56. Pushed by rkflx into branch 'master'. Update to synctex 1.19 Summary: This should prevent crashes when reloading some synctex-enabled pdf files created with newer versions of TeXLive. We also gain bugfixes, features and improved accuracy from the last 6 years of synctex development. Procedure followed: - svn co svn://tug.org/texlive/trunk/Build/source/texk/web2c/synctexdir - Check out revision 45150 - Update files present in core/synctex/* - Adapt Okular code to changes - Review and drop or update/apply old patches using quilt - Create missing patches for local synctex changes - New patch: Omit warning message when opening non-synctex pdf - Two new patches to fix more compiler warnings - New patch: Plug multiple leaks and prevent a segfault TODO for later: - Move sync file detection code to Okular to never call into synctex C code for non-synctex files - Evaluate feasibility of upstreaming all patches for TeXLive 2018 and using synctex as a library FIXED-IN: 17.12.0 Test Plan: - No crash in synctex on reloading empty.pdf from bugreport anymore. - Shift-clicking on a word in a simple pdf opens Kate with the corresponding tex line. - Forward and backward search in Kile seems to work. - Works with synctex files from both TeXLive 2015 and 2017. - PartTest::testForwardPDF still passes. - No additional memory leaks in autotests and with basic synctex and non-synctex usage of Okular. Reviewers: #okular, sander, #kile, aacid Reviewed By: #okular, aacid Subscribers: mludwig, aacid Tags: #okular Differential Revision: https://phabricator.kde.org/D7594 M +4 -4 autotests/parttest.cpp M +5 -5 core/document.cpp M +1 -1 core/document_p.h M +9 -8 core/synctex/patches/00-disable-SYNCTEX_INLINE.diff D +0 -42 core/synctex/patches/01-fix-win32-define.diff M +51 -12 core/synctex/patches/04-gcc-specify-printf-format.diff D +0 -13 core/synctex/patches/05-fix-error-formats.diff M +10 -9 core/synctex/patches/06-mingw-_synctex_error.diff D +0 -21 core/synctex/patches/07-synctex_scanner_new_with_output_file-reset-mode.diff M +29 -23 core/synctex/patches/08-fix_cpp_comments.diff D +0 -22 core/synctex/patches/09-fix_path_comparison.diff A +17 -0 core/synctex/patches/10-fix-typo.diff A +49 -0 core/synctex/patches/11-fix-unused-parameters-warnings.diff A +17 -0 core/synctex/patches/12-omit-no-file-warning.diff A +326 -0 core/synctex/patches/13-fix-Wundef-warnings.diff A +62 -0 core/synctex/patches/14-fix-misc-compiler-warnings.diff A +54 -0 core/synctex/patches/15-prevent-leaks-and-segfault.diff M +6 -4 core/synctex/patches/series M +8471 -4038 core/synctex/synctex_parser.c M +410 -332 core/synctex/synctex_parser.h A +552 -0 core/synctex/synctex_parser_advanced.h [License: BSD X11 (BSD like)] M +1 -1 core/synctex/synctex_parser_local.h A +246 -0 core/synctex/synctex_parser_readme.md D +0 -141 core/synctex/synctex_parser_readme.txt M +176 -92 core/synctex/synctex_parser_utils.c M +39 -19 core/synctex/synctex_parser_utils.h M +1 -1 core/synctex/synctex_parser_version.txt https://commits.kde.org/okular/bd20e48c3c8c82ed11ae73aae0467c8ef49fca3b -- You are receiving this mail because: You are watching all bug changes.