https://bugs.kde.org/show_bug.cgi?id=383281

Alvin Wong <alvinhoc...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
                   |ta/754ab2536610d2c4a6f5c822 |ta/6ddc51090990c7e270540d83
                   |0cd294904b13cb33            |f9e7a129132f4ccf

--- Comment #8 from Alvin Wong <alvinhoc...@gmail.com> ---
Git commit 6ddc51090990c7e270540d83f9e7a129132f4ccf by Alvin Wong.
Committed on 19/08/2017 at 09:32.
Pushed by alvinwong into branch 'master'.

Attempt to restore OpenGL 2.1 support on non-OSX systems

Partially reverts d0a329fa4d83576d729baae5a0f65f5b7810f289 (D4506)
and reverts the effect of 96835a05b874abe85b95e1aff525faa4a91368a8.

`KisOpenGLCanvas2` inheritting from a versioned `QOpenGLFunctions_x_x`
isn't the best idea just to get `glLogicOp`, so I try to use an
alternative method to get it.

`glLogicOp` is supposed to be in OpenGL core functions since full
desktop OpenGL 1.0, just never had been a function in OpenGL ES 2.0 or
above, so it should be available even with `QOpenGLFunctions_1_0`. I
used `QOpenGLFunctions_2_1` just because that's the minimum version we
seem to supported before 3.2 release.
Related: bug 363770
Differential Revision: https://phabricator.kde.org/D7405

M  +3    -2    libs/ui/opengl/kis_opengl.cpp
M  +20   -0    libs/ui/opengl/kis_opengl_canvas2.cpp
M  +6    -3    libs/ui/opengl/kis_opengl_canvas2.h

https://commits.kde.org/krita/6ddc51090990c7e270540d83f9e7a129132f4ccf

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to