https://bugs.kde.org/show_bug.cgi?id=381835
Bug ID: 381835
Summary: RunnerManager::queryFinished never emitted
Product: frameworks-krunner
Version: unspecified
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: general
Assignee: k...@privat.broulik.de
Reporter: k...@davidedmundson.co.uk
Target Milestone: ---
QObject::connect(job->decorator().data(),
SIGNAL(done(ThreadWeaver::JobPointer)), q,
SLOT(jobDone(ThreadWeaver::JobPointer)));
Queue::instance()->enqueue(job);
is broken.
In order to get signals from the decorator you have to actually run the
decorator, not the decoratee (which is a bit odd and clearly not a decorator
pattern at all)
Changing that is harder than it would seem because Runner dynamic_casts the
jobs to FindMatchJob all over the place as it manually bookeeps the jobs
despite bookmarking jobs being *literally the entire point of threadweaver*.
--
You are receiving this mail because:
You are watching all bug changes.
