https://bugs.kde.org/show_bug.cgi?id=364317

Kevin Funk <kf...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kde
                   |                            |vplatform/3ed8698f1baca73e2
                   |                            |d7cb4400c90e6950a8ad623
   Version Fixed In|                            |5.1.2
         Resolution|---                         |FIXED

--- Comment #2 from Kevin Funk <kf...@kde.org> ---
Git commit 3ed8698f1baca73e2d7cb4400c90e6950a8ad623 by Kevin Funk, on behalf of
Christoph Roick.
Committed on 21/06/2017 at 17:35.
Pushed by kfunk into branch '5.1'.

Fix crash when trying to kill a finished NativeAppJob

Summary:
- when starting the same job twice, a dialog pops up,
  asking whether to kill the running job
- if the job finished meanwhile, the running job instance
  ceases to exist and accessing its member causes a crash
- probably the same as Bug 364317

Solution:
- add a check for existence of the job after the dialog
FIXED-IN: 5.1.2

Test Plan:
- start the same job twice (a unit test for instance)
- click on "Yes" (do kill the running job), if the dialog
  pops up, after the job finished

Reviewers: #kdevelop, apol

Reviewed By: #kdevelop, apol

Subscribers: apol, kdevelop-devel

Differential Revision: https://phabricator.kde.org/D6286

M  +1    -1    plugins/execute/nativeappjob.cpp

https://commits.kde.org/kdevplatform/3ed8698f1baca73e2d7cb4400c90e6950a8ad623

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to