https://bugs.kde.org/show_bug.cgi?id=368529
--- Comment #14 from Elliott Hughes <e...@google.com> --- > Redone, using the house conditionalisation scheme, in r16386. Please test. (sorry, didn't have time to look until now.) as i explained already, that's wrong. anywhere you have this idiom in the code and it doesn't include *all* the Android variants -- which right now is at least 30 places, almost everywhere you have this idiom -- it's wrong. why not just say __ANDROID__ for OS-details (like /system/bin/sh versus /bin/sh) or __BIONIC__ if it's a libc-specific thing? you already make use of __GLIBC__ and __UCLIBC__ and [a home-grown] MUSL_LIBC, but won't use __BIONIC__? that doesn't make any sense. (see comment 8 on this bug or https://bugs.kde.org/show_bug.cgi?id=379878 if you want more examples of bugs caused by this idiom.) -- You are receiving this mail because: You are watching all bug changes.
