https://bugs.kde.org/show_bug.cgi?id=368529
Julian Seward <jsew...@acm.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsew...@acm.org
--- Comment #12 from Julian Seward <jsew...@acm.org> ---
(In reply to Elliott Hughes from comment #8)
> (In reply to Ivo Raisr from comment #7)
> > I am a little worried about this condition in the patch:
> >
> > #if defined(ANDROID) && defined(__clang__)
> >
> > Nowhere in Valgrind sources we currently base a decision on naked "ANDROID".
> > It is always this combo (from vki-linux.h):
> >
> > #if defined(VGPV_arm_linux_android) || defined(VGPV_x86_linux_android) \
> > || defined(VGPV_mips32_linux_android) \
> > || defined(VGPV_arm64_linux_android)
> > ...
> > #endif /* defined(VGPV_*_linux_android) */
>
> that idiom is kind of insane in most cases. it also leads to bugs like
> https://bugs.kde.org/show_bug.cgi?id=339945 or
> https://bugs.kde.org/show_bug.cgi?id=379764 where you have to manually
> maintain these lists.
No, I object. The platform conditionalisation is like it is for a good
reason, which is that ad-hoc ifdeffery, which this __ANDROID__ define is,
eventually leads to a big mess which is hard to modify and reason about.
We have to keep the system maintainable on a bunch of targets, not just
Android.
Please use the existing system where you can. We want to continue to
support Android well, but that can't be at the expense of getting into
a confusing maze of ifdefs.
--
You are receiving this mail because:
You are watching all bug changes.
