https://bugs.kde.org/show_bug.cgi?id=378497

Thomas Fischer <fisc...@unix-ag.uni-kl.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Version Fixed In|                            |0.8
      Latest Commit|                            |https://commits.kde.org/kbi
                   |                            |btex/b89b498f719361c6026bed
                   |                            |e4893a5456dc3c34fe

--- Comment #3 from Thomas Fischer <fisc...@unix-ag.uni-kl.de> ---
Git commit b89b498f719361c6026bede4893a5456dc3c34fe by Thomas Fischer.
Committed on 07/04/2017 at 19:26.
Pushed by thomasfischer into branch 'master'.

Remove 'static' from QObject-derived objects

Objects of classes that are derived from QObject are supposed to be in a
clear parent-children relation: at object creation, a QObject-derived
parent is passed to the QObject constructor.
QObject's destructor will take care that all child objects will be
destroyed as well.
This conflicts with QObject-derived objects that are declared 'static',
as this may imply a different life span than the object's parent.
This may lead to double-destroy situations crashing KBibTeX.

This commit will avoid having the 'static' keyword at variable
declarations of QObject-derived objects.
FIXED-IN: 0.8

M  +1    -1    src/gui/preferences/settingsidsuggestionswidget.cpp
M  +0    -4    src/io/fileimporterbibtex.cpp
M  +0    -1    src/io/fileimporterbibtex.h
M  +1    -1    src/networking/zotero/items.cpp

https://commits.kde.org/kbibtex/b89b498f719361c6026bede4893a5456dc3c34fe

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to