https://bugs.kde.org/show_bug.cgi?id=208625
David Faure <fa...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |NEEDSINFO
Resolution|--- |WAITINGFORINFO
--- Comment #34 from David Faure <fa...@kde.org> ---
OK, let's see.
First, trying to reproduce Alvaro's initial steps (with the path in step 1
adjusted for Kf5) :
1. rm /tmp/dolphin*
2. open dolphin and split the window
3. go to a remote machine via SFTP
4. copy a file from the remote machine to the local one (using drag-n-drop)
I copied a 102 MB file and a 3.7 MB file and no temp file was created, not even
during the copy.
Then Dmitry's comment says it might be about previews, I tried enabling
previews in the toolbar, works locally, no effect on sftp. This is because
Dolphin's preferences dialog says "Skip previews for remote files over 0MB".
If I change that to 10 MB, then indeed I get a preview of the image I uploaded
- but still no dolphin temp file left over in /tmp.
Now trying the same with trash:/, preview works, no temp file left over.
Now looking at the code: there is a QTemporaryFile in KIO::PreviewJob,
obviously, for remote files where the thumbnail plugin doesn't support KIO. But
the temp file is deleted in the next step.
KIO::PreviewJobPrivate::getOrCreateThumbnail: Using temp file
"/tmp/dolphin.B12772"
KIO::PreviewJob::slotResult: Deleting temp file "/tmp/dolphin.B12772"
(additional debug output I just added)
So a temp file leak would only happen if the first step happens but not the
second step.
Reading the code, I don't see how this can ever happen. There is no code path
where we wouldn't get to the second step.
The only course of action I can suggest is that someone who can reproduce the
bug applies the patch below to their kio build and reports the results.
http://www.davidfaure.fr/2017/previewjob.cpp.diff
--
You are receiving this mail because:
You are watching all bug changes.
