https://bugs.kde.org/show_bug.cgi?id=376754
--- Comment #3 from Marco Martin <notm...@gmail.com> --- Git commit 2b3e8dfe866abc5b2971eecb4c52843e73be1893 by Marco Martin. Committed on 28/02/2017 at 12:35. Pushed by mart into branch 'master'. move setImagePath logic into updateFrameData() Summary: make sure the framedata creation/destruction is completely in updateFrameData, makes easier to track and possible to use the repaintsblocked logic. now only one framedata instance should be created at startup. Test Plan: * autotests pass, plasma runs ok, crash on 376754 not reproducible anymore * possible to have a plasmashell session start without the creation of a single svg renderer (startups after the first when the cache is generated) * on qml profiler, framesvgitem creation is ~12 msecs the first one created, ~2-300 musecs the subsequent ones, seems to be a bit better than before the whole refactor started * tried against the latest patches that remove the binding loops, still correct rendering and no binding loop * tried with both empty and existing cache in place Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: davidedmundson, plasma-devel, #frameworks Tags: #frameworks, #plasma Differential Revision: https://phabricator.kde.org/D4707 M +78 -88 src/plasma/framesvg.cpp M +5 -2 src/plasma/private/framesvg_p.h M +2 -3 src/plasma/svg.cpp https://commits.kde.org/plasma-framework/2b3e8dfe866abc5b2971eecb4c52843e73be1893 -- You are receiving this mail because: You are watching all bug changes.
