https://bugs.kde.org/show_bug.cgi?id=375137

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kde
                   |                            |plasma-addons/407168327b93a
                   |                            |68865fa8367401d20673360e7c7

--- Comment #3 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 407168327b93a68865fa8367401d20673360e7c7 by David Edmundson.
Committed on 16/01/2017 at 22:34.
Pushed by davidedmundson into branch 'Plasma/5.9'.

Fix pixel alignment and non-standard height in QuickShare delegate

Summary:
The current code had height: button.height * 1.2
then centered the button within it, which can result in non-pixel
aligned y values, leading to rendering issues.

We don't need to specify the height explicitly, it's done by ListItem if
we fix the underlying binding loop. This gives the delegate the correct
size of button height + margins.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4166

M  +2    -2    applets/quickshare/plasmoid/contents/ui/ShareDialog.qml

https://commits.kde.org/kdeplasma-addons/407168327b93a68865fa8367401d20673360e7c7

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to