https://bugs.kde.org/show_bug.cgi?id=320666
--- Comment #22 from Mario Frank <mario.fr...@uni-potsdam.de> --- (In reply to caulier.gilles from comment #21) > Mario, > > All VM are ready at home. I can do it this week end including patch, not > before. > > Note : remember that 5.4.0 will be release this Sunday evening. > > Gilles Hey Gilles, I tested the patch again yesterday evening. The database handling works as expected. No errors were there. The patch reduces the amount of DB usage since the similarity is only stored for duplicates. Fuzzy search, drop search and sketch search do not use similarities from DB any more. Since these HAAR searches are done on thumbnail load anyway which also includes searching for the similar pictures, I just forward the similarities. The current similarity is stored in the ImageInfo but not persisted in the database. Thus, there are no DB changes with this approach. I eliminated the storing of the current fuzzy reference image from application settings since I do not need it any more. Also, I use less SIGNAL/SLOT communication which reduces the probability of bugs a lot. I do not have to react on context switches anymore. The only things that cannot be solved easily: 1) The column Similarity is shown for the table view everywhere if it was selected. But only when there is a similarity, the column entry is non-zero. So, in every table view that is not in the context of the fuzzy search sidebar, the images have a similarity of 0.0. I do not see a solution to hide that column dynamically. But since many properties (e.g. geo location) are not set for every picture, I would not see it as a glitch. 2) In sketch search, the similarity values are in fact the similarity scores normalised to a positive value between 0 and 100. It is not a percentage. Nevertheless, this is no dysfunction but intended for now. Since the patch also fixes bugs like the context menu problems https://bugs.kde.org/show_bug.cgi?id=374191 , reduces DB usage overhead and polishes my former SIGNAL/SLOT communication, I would like to merge it as soon as possible. What do you think? -- You are receiving this mail because: You are watching all bug changes.
