https://bugs.kde.org/show_bug.cgi?id=504198
cwo <cwo....@posteo.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult
|imedia/elisa/-/commit/19f9d |imedia/elisa/-/commit/e7ded
|e65f1d6814efb7ce2d31b2f62f0 |f3b02b0526dcd086972a4369a8e
|3df8ca02 |fb8746cd
--- Comment #3 from cwo <cwo....@posteo.net> ---
Git commit e7dedf3b02b0526dcd086972a4369a8efb8746cd by Christoph Wolk.
Committed on 23/05/2025 at 20:51.
Pushed by cwo into branch 'release/25.04'.
qml/ContextView: don't show Lyrics when they're invisible
ContextView attempts to hide the lyrics when not selected or in wide
mode by setting the containing Item's implicitWidth to zero. But this
doesn't work (anymore?); the lyrics are still displayed, centered around
the zero-width position where they would appear (so half off-screen) and
overlapping the metadata area. To hide text this way, clip must be set
to true.
Instead, we might as well directly set visible; this seems clearer than
an implicitWidth + clip trick and is likely faster as well as no
separate checks are necessary about what would fit (which is nothing
anyway).
FIXED-IN: 25.04.2
(cherry picked from commit 19f9de65f1d6814efb7ce2d31b2f62f03df8ca02)
Co-authored-by: Christoph Wolk <cwo....@posteo.net>
M +1 -0 src/qml/ContextView.qml
https://invent.kde.org/multimedia/elisa/-/commit/e7dedf3b02b0526dcd086972a4369a8efb8746cd
--
You are receiving this mail because:
You are watching all bug changes.
