https://bugs.kde.org/show_bug.cgi?id=503969
--- Comment #5 from [email protected] --- Hello Mark, (In reply to Mark Wielaard from comment #2) > This is pretty hard to review without knowing what is intended. > > As far as I can see there are a couple changes: > - ORIG_PWD isn't used anymore and is replace by SCRIPT_SRC=$(dirname $0) > - This makes it possible to invoke the script from anywhere My original goal was to allow for a build directory separate from the source tree. To be clear I mean doing something like ../valgrind/configure --prefix .... This appears to partly work, but specifically the vg-in-place script still ends up being created within the source tree. So, I gave up. This relict change however looks good to me although it's not strictly needed for our use-case. > - LOGDIR is redefined to no longer use the valgrind-ltp-logs but a more > generic tests subdir > - The buildbot relies on the old name and so should be adjusted to deal > with "tests" My intent in this case was to align the structure of the logs with the one coming from my RHEL valgrind-ltp tester here: https://builder.sourceware.org/testruns/?op_mode=search_exact&has_keyvalue_k=testrun.gitdescribe&has_keyvalue_op=glob&has_keyvalue_v=*ltp* > - The summary.log isn't generated anymore Yes, that's intentional. This ltp tester isn't actually automake based. But the automake log format is the one I want to use for bunsen upload. So this patch mimics the automake log format. That said, for every testcase two log files are synthesized: a .log file containing the actual test log details, and a .trs file that encodes the test result (that's echo ":test-result: $rv" > $LOGDIR/$exe.trs). There is one more thing the bunsen parser needs to successfully recognize our set of logs as automake based: the test-suite.log file. No matter it is empty. But it's there and with that bunsen can parse our logs as shown above in Comment #1. This hopefully explains most of the following notes too ... > - myLog isn't used anymore and is replaced by echo -e which means > - That backslash escapes are now handled (no more literal \n in the output) > - The individual test summary files aren't generated anymore > - Inside the LOGDIR a couple of files are generated: > - test-suite.log which is kept empty? Was this intended to be the new > summary.log? > - Various .bunsen* files. Are these necessary when the buildbot does the > bunsen uploading? ... except for this ^^. These .bunsen files are there to provide more test run context to bunsen. These need to be generated on the test system. But it doesn't necessarily need to be part of valgrind source. Another option is to make it part of the buildbot scripts responsible for executing the testsuite and uploading the test results to bunsen. Moving this part out of this patch towards the build bot scripts is possible. > - Two automake style testlog files are generated > - the $exe.log which contains something on FAIL, but is empty on PASS (is > that intended?) > - a $exe.trs file that contains the PASS or FAIL status. > > Please review my understanding and update whether this is expected behaviour. Thank you for the review. Please let me know if my comments don't answer your questions. Do you prefer to move generation of these .bunsen* files to the buildbot scripts? -- You are receiving this mail because: You are watching all bug changes.
