https://bugs.kde.org/show_bug.cgi?id=395241

--- Comment #38 from Michael Miller <michael_mil...@msn.com> ---

> https://www.youtube.com/watch?v=8UWhkx3GjoA
> 
> After the images are found and added to the album there are a total of 10
> thumbnails. 
> 
> Accessing People > Michael, viewing the pre-tagged face does not create a
> new thumbnail.
> Accessing People > Unknown creates two new thumbnails for a total of 12
> thumbnails. 
> 
> Perhaps only the first face in a photo is getting its thumbnail pre-created? 
> 
> Or, looking at records 8 & 12 or 10 & 11, perhaps there is some rounding
> happening making the thumbnail identifiers not match. The "rect" parameter
> seems to only be off by 1 pixel in various dimensions.

Gilles and Maik,
If you haven't already watched the video, please watch it soon.  It looks like
there is a dysfunction comparing/creating new thumbnails.  I think it's because
we store the rect in pixels and Exif stores the rect as float percentages.  My
guess is when converting the Exif RectF to Rect pixels there's a chance
floating point rounding will be off by a pixel.  The other possible cause is
we're padding the face rect somewhere, but I'm not adding the same padding when
I create the thumbail in the face pipelines.

Let's discuss this offline to come up with a fix.

Michael, thank you so much for your time.  This is incredibly helpful.

Cheers,
Mike

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to