https://bugs.kde.org/show_bug.cgi?id=466368
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Latest Commit| |https://invent.kde.org/grap
| |hics/krita/-/commit/ea2372b
| |28fbde357ed65ad332777ae0a4e
| |b9d775
Resolution|--- |FIXED
--- Comment #2 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit ea2372b28fbde357ed65ad332777ae0a4eb9d775 by Dmitry Kazakov.
Committed on 13/12/2024 at 12:13.
Pushed by dkazakov into branch 'master'.
[critical] Fixed opacity being applied twice(!) in some brushes
It seem like during the brushes port to lager in 2022, I made a
mistake in understanding what is `m_useSeparateStrengthValue` in
`KisCurveOption`. It caused `KisOpacityOption` to apply opacity twice
for some of the brushes.
It means that for two years when the user selected any opacity for
the brush, the actual opacity used for the brush was **squared**.
I.e. when the user selected opacity 0.5, the real opacity was 0.25.
This patch fixes the issue, but it **changes behavior** of existing
brush presets.
The list of affected brush engines:
* Curve
* Clone
* Deform
* Hairy
* Hatching
* Sketch
* Spray
The most popular brush engines, like Pixel and Color Smudge are **not**
affected.
I'm not sure this change should be backported to krita/5.2 since it
changes behavior.
CC:kimages...@kde.org
M +1 -1 plugins/paintops/colorsmudge/kis_colorsmudgeop.cpp
M +2 -3 plugins/paintops/curvebrush/kis_curve_paintop.cpp
M +2 -4 plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.cpp
M +2 -3 plugins/paintops/deform/kis_deform_paintop.cpp
M +2 -3 plugins/paintops/hairy/kis_hairy_paintop.cpp
M +2 -3 plugins/paintops/hatching/kis_hatching_paintop.cpp
M +1 -1 plugins/paintops/libpaintop/KisFlowOpacityOption.cpp
M +17 -9 plugins/paintops/libpaintop/KisOpacityOption.cpp
M +6 -2 plugins/paintops/libpaintop/KisOpacityOption.h
M +2 -3 plugins/paintops/sketch/kis_sketch_paintop.cpp
M +2 -3 plugins/paintops/spray/kis_spray_paintop.cpp
https://invent.kde.org/graphics/krita/-/commit/ea2372b28fbde357ed65ad332777ae0a4eb9d775
--
You are receiving this mail because:
You are watching all bug changes.
